From 2439c714e5714d98512138b78a8bc80a1ebcfa5b Mon Sep 17 00:00:00 2001
From: Noah Petherbridge <root@kirsle.net>
Date: Wed, 21 Jun 2023 18:36:42 -0700
Subject: [PATCH] Notifications: make the Like button a button to avoid
 hyperlink issue

---
 web/templates/account/dashboard.html | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/web/templates/account/dashboard.html b/web/templates/account/dashboard.html
index e028464..e8e47d4 100644
--- a/web/templates/account/dashboard.html
+++ b/web/templates/account/dashboard.html
@@ -425,11 +425,9 @@
                                                 {{if ne $Body.Photo.UserID $Root.CurrentUser.ID}}
                                                 <div class="mt-1">
                                                     {{$Like := $Root.PhotoLikeMap.Get $Body.PhotoID}}
-                                                    <a href="#" class="button is-small nonshy-like-button"
+                                                    <button type="button" class="button is-small nonshy-like-button"
                                                         data-table-name="photos" data-table-id="{{$Body.PhotoID}}"
-                                                        title="Like" onclick="return false">
-                                                        <!-- TODO: the return false above fixes a bug on mobile where it jumps to
-                                                             the top of page, despite preventDefault() and it doesn't happen on desktop! -->
+                                                        title="Like">
                                                         <span class="icon{{if $Like.UserLikes}} has-text-danger{{end}}"><i class="fa fa-heart"></i></span>
                                                         <span class="nonshy-likes">
                                                             Like
@@ -437,7 +435,7 @@
                                                                 ({{$Like.Count}})
                                                             {{end}}
                                                         </span>
-                                                    </a>
+                                                    </button>
                                                 </div>
                                                 {{end}}
                                             </div>