Site Gallery: Filter parameters and pagination #1
Labels
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: nonshy/website#1
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The pager buttons on the site gallery don't take all the query parameters for selected filters into account when loading another page, and there's a LOT of those params to worry about now.
Stuffing a bunch of template tags like
href="{{.Request.URL.Path}}?view={{.ViewStyle}}&page={{.Pager.Previous}}"
in there gets tedious fast too.Create a template function which can just take "whatever the query parameters currently are" and add the page number do it (or update the existing page param if one already existed).
Fixed in
8085e092bc